Remove support for pre v16 joi #4474
Open
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
approved these changes
Jan 29, 2024
jonathansamines
approved these changes
Jan 29, 2024
|
@kanongil Is this still a valid PR? Any chance you can update it if need be? We're converging for a major release and may include this if it's ready. |
|
There might be an issue with this PR, let me check… |
kanongil
commented
Nov 29, 2024
There was a problem hiding this comment.
We need to keep support for non-async validators, since an external validator might only use this.
Ie. I have removed the logic changes, and this patch just replaces the legacy joi test, with a custom non-async validator test.
The test failures seem unrelated to this PR. Note that node@14 also a fails while reporting a false positive.
kanongil
added
test
|
Note that since this no longer changes the logic, this patch could also be applied against the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last
[email protected]was released more than 4 years ago. It should be safe to drop (in a breaking release).This also removes several npm deprecation notices when installing dev dependencies.